Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make panGesture a public property #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ajsharp
Copy link

@ajsharp ajsharp commented Jan 12, 2014

It would be nice if panGesture were a public property. Doing so would allow library users to implement a delegate or add targets to the gesture in order to better control it. For example, it's nice to be able to restrict the area that the pan applies to the left portion of the screen. Here's how I do this by implementing one of UIGestureRecognizer delegate methods:

-(BOOL)gestureRecognizerShouldBegin:(UIGestureRecognizer *)gestureRecognizer {
    if ([gestureRecognizer locationInView:gestureRecognizer.view].x < 70.0) {
        return YES;
    }
    return NO;
}

@nverinaud
Copy link
Owner

Hum...It could be safer to make the setter private aka readonly property in the .h.

@ajsharp
Copy link
Author

ajsharp commented Feb 24, 2014

Yea, good point. So you'd be in favor of making the setter private but the getter public?

@nverinaud
Copy link
Owner

Yep !

@ajsharp
Copy link
Author

ajsharp commented Jun 28, 2014

@nverinaud Updated this pull request. I think I implemented what we've discussed 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants